Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stretched components height #149

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

abdulhaseeb13mar
Copy link
Contributor

@abdulhaseeb13mar abdulhaseeb13mar commented Oct 9, 2023

fixes #142

innerWidth
2228
innerHeight
1581

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for chipper-sunburst-578cfe ready!

Name Link
🔨 Latest commit 288c82f
🔍 Latest deploy log https://app.netlify.com/sites/chipper-sunburst-578cfe/deploys/65258e2283ca7c00084f49ef
😎 Deploy Preview https://deploy-preview-149--chipper-sunburst-578cfe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nguvictor
Copy link
Member

Any chance that it can fixed this using the daisyui or tailwind classes?

@EvgeniiaVak EvgeniiaVak changed the title Issue 142 fix stretched components height Oct 10, 2023
@EvgeniiaVak
Copy link
Member

@abdulhaseeb13mar
could you also fix navbar for pages with little content?
check out https://deploy-preview-149--chipper-sunburst-578cfe.netlify.app/terms
Screenshot 2023-10-10 at 16 08 54

Comment on lines 89 to 91
.custom-auto-row-grid {
grid-auto-rows: auto auto auto 1fr 1fr;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can those be replaced by a built-in tailwindcss class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't find equivalent or custom arbitrary class for auto-grid-rows. let me know if you find any. i will update

Copy link
Member

@EvgeniiaVak EvgeniiaVak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forgot to move to "changes requested"

@abdulhaseeb13mar
Copy link
Contributor Author

abdulhaseeb13mar commented Oct 10, 2023

@abdulhaseeb13mar could you also fix navbar for pages with little content?

check now @EvgeniiaVak . i have updated the layout with css conditions for home or rest of the pages. because i think the rest of the pages are going to have a similar layout like /terms. only the homepage "/" needed to have a different Grid layout.

@@ -85,3 +85,12 @@ input[type="number"]::-ms-clear {
[data-theme] {
background-color: hsl(var(--b2) / var(--tw-bg-opacity, 1));
}

/* Grid layout for home page */
.custom-auto-row-grid[data-path="/"] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the path for this page will later change to /trade (and the landing page / will have different content, if the custom class names are unavoidable, please add another name and use it for the trading layout somewhere. you can add a div to wrap the trade page content if it doesn't exist yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's alright, when it will be moved to the trade page, we just need to change this :

.custom-auto-row-grid[data-path="/"]

to this:

.custom-auto-row-grid[data-path="/trade"]

and the layout will work fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@@ -85,3 +85,12 @@ input[type="number"]::-ms-clear {
[data-theme] {
background-color: hsl(var(--b2) / var(--tw-bg-opacity, 1));
}

/* Grid layout for home page */
.custom-auto-row-grid[data-path="/"] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@EvgeniiaVak EvgeniiaVak merged commit 65e7c93 into DeXter-on-Radix:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Components height issues
3 participants